Repository navigation
fix(dev-server): listen on 127.0.0.1 by default - #845
Merged
Merged
Conversation
Add a --host flag (LD_HOST / config 'host') so the server can still be exposed with --host 0.0.0.0 when running in a container or for other devices on the network. Co-Authored-By: wchieng@launchdarkly.com <williamchieng1991@gmail.com>
Contributor
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
Contributor
|
@BugBot review |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 4109095. Configure here.
…und to loopback Co-Authored-By: wchieng@launchdarkly.com <williamchieng1991@gmail.com>
ld-ahartmann
approved these changes
Oct 5, 2026
2 of 3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The dev server listened on
0.0.0.0with no authentication. Anyone on the same network could read and override flags, replace the database via backup restore, or post unbounded SDK events.--host(alsoLD_HOST/ confighost). It defaults to127.0.0.1.-p, or reach it from a phone or emulator on the LAN, you now need--host 0.0.0.0. This needs a release note.debug_eventsretention will come in a separate PR.Link to Devin session: https://app.devin.ai/sessions/33518e0108ac4ea3aaec26dd594dbd62
Open in Devin Desktop: https://app.devin.ai/desktop/session/33518e0108ac4ea3aaec26dd594dbd62?variant=devin
Requested by: @wchieng
Note
Overview
Security-focused behavior change: the dev server no longer binds to all interfaces (
0.0.0.0) by default; it listens on127.0.0.1unless overridden.Adds a persistent
--hostflag (default127.0.0.1),hostinldcli config, andLD_HOSTvia viper. The listen address is built withnet.JoinHostPortinstead of hard-coded0.0.0.0. When the server starts on loopback/localhost, it logs a hint to pass--host 0.0.0.0for Docker, LAN, or emulator access. Config help golden andUpdatetests cover the new setting.Reviewed by Cursor Bugbot for commit ec0da06. Bugbot is set up for automated code reviews on this repo. Configure here.